fix: add buffer limits to appsrc elements#500
Merged
Conversation
… growth Without max_bytes/max_time, appsrc queues grow indefinitely when downstream is not consuming (e.g. unlinked pipeline). Observed 55 MB / 285 seconds accumulated in a media player appsrc. Adds shared constants for video (20 MB), audio (2 MB), and time (10 s) limits across media player and WHIP blocks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_bytes,max_time, andleaky_typeto media player and WHIP appsrc elements to prevent unbounded memory growth when downstream is not consumingblocks/mod.rs: video 20 MB, audio 2 MB, time 10 sTest plan
🤖 Generated with Claude Code