fix(cef): use CEF 122 instead of 126 to match pinned gstcefsrc ABI#507
Merged
fix(cef): use CEF 122 instead of 126 to match pinned gstcefsrc ABI#507
Conversation
CEF 126 introduced a signature change to CefRequestHandler::OnRenderProcessTerminated (added error_code and error_string parameters), breaking the gstcefsrc pin (0e470f51fd) which uses the 2-arg signature from CEF 122. Upstream gstcefsrc jumped from CEF 122 straight to CEF 130 with no commit tested against 123-129. Use the version the pin was actually tested against. 122 vs 126 makes no difference for our goal: both predate the Chrome runtime default (CEF 127) and thus neither exhibits the MemoryInfra SIGILL. Chromium 122 (Feb 2024) is still fully capable for HTML overlay rendering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error_code/error_stringparams toOnRenderProcessTerminated, which breaks gstcefsrc commit0e470f51fd(uses the 2-arg CEF 122 signature).Test plan
build-gstcefsrc.ymlsucceeds for both linux-amd64 and linux-arm64gstcefsrc-122.1.13-linux-*.tar.gzartifacts appear ingstcefsrc-depsrelease