feat(vision-mixer): per-input VU meters on multiview overlay#511
Merged
feat(vision-mixer): per-input VU meters on multiview overlay#511
Conversation
Adds one audio input pad per video input plus a dedicated pgm_audio_in pad, wires each through queue -> audioconvert -> level -> fakesink, and renders peak/decay meters in the bottom-left of every multiview tile (plus PVW and PGM). Grouped PVW/PGM layouts get one meter per sub-tile. Gated by a new show_vu_meters block property (default on). Bar fill tracks peak, tick tracks decay, both driven by the level element at 100 ms intervals. Overlay state uses AtomicU8 slots so the bus handler writes lock-free and the Cairo render stays off the hot streaming path. Dirty check hashes quantized meter values so idle or silent audio does not trigger re-renders. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
srperens
force-pushed
the
feat/vision-mixer-vu-meters
branch
from
a677c5f to
58b8e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgm_audio_inpad on the vision mixer; each audio branch runsqueue → audioconvert → level → fakesinkand feeds the overlay via bus messages.show_vu_metersblock property (default on) togglable live via anAtomicBool. Dirty-check hashes quantized meter values so idle/silent audio doesn't trigger unnecessary re-renders; meter values are stored asAtomicU8slots so the bus handler writes lock-free.Test plan
cargo checkfrom workspace rootcargo test --test openapi_test(snapshot unchanged)cargo test --test pipeline_lifecycle_test(no circular references)cargo test vision_mixer(15 passed)show_vu_meters=false, confirm meters disappear and no re-renders are triggered🤖 Generated with Claude Code