Dialect-aware DELETE-query rendering & DELETE LIMIT support#20
Merged
ez-plugins merged 4 commits intomainfrom Apr 18, 2026
Merged
Dialect-aware DELETE-query rendering & DELETE LIMIT support#20ez-plugins merged 4 commits intomainfrom
ez-plugins merged 4 commits intomainfrom
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
DELETErendering -SqlDialectnow exposes arenderDelete(Query)method that generatesa fully dialect-aware
DELETE FROM … WHERE …statement, including proper identifier quoting per dialect.Improvements
DELETE … LIMIT-MySqlDialectnow appends aLIMITclause toDELETEstatements when a limitis set on the query.
DELETE … LIMIT-SqliteDialectdoes the same; standard dialect silently ignoreslimitonDELETEto remain ANSI-compliant.appendWhereClauseandappendConditionFragmentinAbstractSqlDialectpromoted toprotectedsosubclasses can reuse the shared WHERE rendering logic.
Tests
AbstractSqlDialectDeleteTestcovering parameter parity withrender(), identifier quoting,LIMITbehaviour across all three dialects, andINplaceholder generation.Chores
Dialect-aware DELETE rendering subsection with code examples for all three dialects.