Skip to content

Adds the ability for ASM tasks to import to different partititions#1316

Merged
jasonrahm merged 1 commit intoF5Networks:developmentfrom
caphrim007:bugfix.allow-asm-tasks-to-import-to-partition
Nov 1, 2017
Merged

Adds the ability for ASM tasks to import to different partititions#1316
jasonrahm merged 1 commit intoF5Networks:developmentfrom
caphrim007:bugfix.allow-asm-tasks-to-import-to-partition

Conversation

@caphrim007
Copy link
Copy Markdown
Contributor

Issues:
Fixes #1315

Problem:
Previously you could not import an ASM policy to a specific partition

Analysis:
This patch provides two methods to import an ASM policy to a partition.

First, you can specify the fullPath argument. This is directly mapped
to the fullPath attribute of the resource and ASM will import the partition
that is specified in the full path. ex, /Partition1/my_policy

Second, you can specify a combination of 'name' and 'partition' to the
create method. This method is just a convenience wrapper on top of
the aforementioned method. In the end, this method will generate the
fullPath for you. This method is more inline with other APIs that
accept a 'partition' argument

Tests:
functional

Issues:
Fixes F5Networks#1315

Problem:
Previously you could not import an ASM policy to a specific partition

Analysis:
This patch provides two methods to import an ASM policy to a partition.

First, you can specify the fullPath argument. This is directly mapped
to the fullPath attribute of the resource and ASM will import the partition
that is specified in the full path. ex, /Partition1/my_policy

Second, you can specify a combination of 'name' and 'partition' to the
`create` method. This method is just a convenience wrapper on top of
the aforementioned method. In the end, this method will generate the
fullPath for you. This method is more inline with other APIs that
accept a 'partition' argument

Tests:
functional
@caphrim007 caphrim007 force-pushed the bugfix.allow-asm-tasks-to-import-to-partition branch from 4a261be to fbb41a9 Compare November 1, 2017 19:09
Copy link
Copy Markdown

@jasonrahm jasonrahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @caphrim007

@jasonrahm jasonrahm merged commit b2f5e1b into F5Networks:development Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants