Fixes Issue #1323 - exists method failing on GTM topology records#1347
Merged
caphrim007 merged 3 commits intoF5Networks:developmentfrom Jan 1, 2018
Merged
Fixes Issue #1323 - exists method failing on GTM topology records#1347caphrim007 merged 3 commits intoF5Networks:developmentfrom
caphrim007 merged 3 commits intoF5Networks:developmentfrom
Conversation
…ecords Problem: The / and ~ characters are disallowed in sdk URLs Resolution: Overload the exists method for topology by applying: kwargs['transform_name'] = True
Contributor
|
Can't set status; build succeeded. |
Author
|
hold off on merge until I hear back from the bug reporter that the fix works for him. I confirmed the behavior and the fix locally, but want to make sure. |
Author
|
@caphrim007 this fixes the problem, but also allows the partition kwarg but likely should not for topology records. Should I pop that kwarg if applied to guard against unintentional issues? |
Contributor
|
@jasonrahm yes. If this changes in the future we can address it with a version check |
Author
|
ok, I'll add that and push later. Thanks |
Contributor
|
Can't set status; build succeeded. |
Author
|
@caphrim007 ready for review |
if statement is not needed when doing popping like this. You can provide pop with a default value
Contributor
|
Can't set status; build succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The / and ~ characters are disallowed in sdk URLs
Resolution: Overload the exists method for topology by applying:
kwargs['transform_name'] = True