Issue #1457 - Allow Example Resource to Load#1460
Merged
wojtek0806 merged 2 commits intoF5Networks:developmentfrom Jun 20, 2018
Merged
Issue #1457 - Allow Example Resource to Load#1460wojtek0806 merged 2 commits intoF5Networks:developmentfrom
wojtek0806 merged 2 commits intoF5Networks:developmentfrom
Conversation
Author
|
don't merge yet, even if the build passes I want to add a unit test for a positive match for an example |
Problem: the example file is a collection kind, which is a kind
mismatch on a resource
Solution: Check for example at end of selflink in the _produce_instance
def and don't error on kind mismatch if present
Files Changed:
- f5/bigip/resource.py
- f5/bigip/test/functional/test_resource.py
jasonrahm
force-pushed
the
fix.examplefiles
branch
from
7fbdc48 to
96b57a3
Compare
tmos 11.5.4 inconsistent
Author
|
ready for review, @caphrim007 or @wojtek0806 |
Contributor
|
this looks fine |
Contributor
|
approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the example file is a collection kind, which is a kind
mismatch on a resource
Solution: Check for example at end of selflink in the _produce_instance
def and don't error on kind mismatch if present
Files Changed: