Commandmixin.variables#432
Merged
swormke merged 6 commits intoF5Networks:0.1from May 20, 2016
Merged
Conversation
Contributor
|
This looks pretty good, but it needs tests! |
Contributor
|
@zancas has been super busy, so I looked at this and am going to merge it because looks like you two have worked on it together and it is pretty straight forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #381 also addreses some of the files listed in #378
f5\bigip\cm__init__.py
f5\bigip\sys\config.py
Problem:
Since we have introduced CommandMixin the allowed commands were not stored as part of meta data.
Analysis:
This patch adds the metadata ._meta_data['allowed_commands'] into ResourceBase class. The reason behind it is that commands can be run against some Collections as well as Resources.
There are few other classes which have hard coded command in the json payload which need to be changed later to fully implement fox for #378
Tests:
Flake8
Functional Tests