Fixes the sshd api#458
Merged
zancas merged 1 commit intoF5Networks:developmentfrom Jun 1, 2016
Merged
Conversation
Contributor
Author
Contributor
Author
Contributor
|
SSHD tests are failing on 11.6.0 vanilla, also I think you need to rebase again to incorporate the latest 2 prs |
caphrim007
force-pushed
the
fix-sshd-class
branch
from
1212609 to
84e15c1
Compare
Issues: Fixes F5Networks#438 Problem: The sshd api was inheriting from Resource instead of ResourceBase and this was causing a uri KeyError Analysis: This patch fixes the inheritence to use the ResourceBase class and also adds functional tests for the sshd api to prevent this from happening in the future. Tests: test/functional/tm/sys/test_sshd.py
caphrim007
force-pushed
the
fix-sshd-class
branch
from
84e15c1 to
d94ef0c
Compare
Contributor
Author
|
@zancas this is now ready for merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #438
Problem:
The sshd api was inheriting from Resource instead of ResourceBase and
this was causing a uri KeyError
Analysis:
This patch fixes the inheritence to use the ResourceBase class and
also adds functional tests for the sshd api to prevent this from
happening in the future.
Tests:
test/functional/tm/sys/test_sshd.py