Feature.active standby cluster#472
Merged
zancas merged 3 commits intoF5Networks:developmentfrom Jun 3, 2016
Merged
Conversation
Contributor
|
Some checks failing... |
pjbreaux
force-pushed
the
feature.active_standby_cluster
branch
from
5bdaab9 to
7745146
Compare
Contributor
Author
|
Travis looks good. Jenkins is not. |
Contributor
|
@pjbreaux re-triggering the build here |
Contributor
|
@pjbreaux please sync your development branch with origin and rebase on top of it. |
Contributor
|
@pjbreaux why were the scale up/downs removed? |
Contributor
Author
|
A few reasons. Adding a device causes a failover event. Also, as I understand it, having more than two devices usually requires multiple traffic groups meaning we would have to manage those for multiple devices as well as manage their fallbacks. We will add it eventually. |
Contributor
|
@smooth-alg see @pjbreaux 's response |
Contributor
Author
|
I'd love to discuss with anyone curious. At least getting requirements around clustering for more than two devices. |
added 3 commits
June 3, 2016 15:56
Issues: Fixes F5Networks#456 and F5Networks#460 Problem: Developers must be able to opt-in to the cluster tests, since they require a set of at least four bigip devices. Also, a trust domain is implemented as a device group on the bigip devices, and we must be able to sync that group when we add members to the trust domain. Analysis: Used pytest.mark.skip to skip cluster tests unless a user has set a key of 'run_cluster_tests' and a value of JSON/YAML truthiness. The trust domain now instantiates a device group manager to sync to that group when adding devices to the trust domain. This is a part of the validation process in the device group and the trust domain. Tests: All unit and functional tests pass
Issues: Fixes F5Networks#471 Problem: In order to minimize feature creep and the ability for users to shoot themselves in the foot, I would like to limit clustering support to handle only two devices. This will be reflected in the code with tests and documentation. Analysis: Modified the code to only allow up to four devices to be clustered, yet the functional tests are there for up to two devices. Four devices is not yet supported. This will be made clear in the customer-facing documentation. It is already clear in the code documentation. Tests: All clustering tests pass against 11.6 and 12.0 VE images
…sterManager not checking device number.
pjbreaux
force-pushed
the
feature.active_standby_cluster
branch
from
08cfe9b to
a84e898
Compare
This was referenced Jun 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zancas
What's this change do?
Improves documentation and code for supporting an active standby cluster.
Any background context?
After talking to jgruber, I realized that having a four-member cluster isn't terribly useful because you still have to manually manage traffic groups. Without this traffic group feature, only an active standby cluster is useful because it uses one traffic group to manage traffic.
Where should the reviewer start?
Start at the new unit tests and then move to the functional tests. The four-member tests have been removed, since testing against two devices is easier than having four running.