Version check clean commits#478
Merged
zancas merged 4 commits intoF5Networks:developmentfrom Jun 2, 2016
zancas:version_check_clean_commits
Merged
Version check clean commits#478zancas merged 4 commits intoF5Networks:developmentfrom zancas:version_check_clean_commits
zancas merged 4 commits intoF5Networks:developmentfrom
zancas:version_check_clean_commits
Conversation
Fixes #379, #452, #461, #462 Problem: SDK needs to be able to run on multiple versions of TMOS. Some API endpoints were not implemented in the base 11.6.0, but exist in 12.x. This SDK needs the ability to verify the TMOS version when instantiating the API classes. Analysis: This update forces the tmos version update upon ManagementRoot instantiation. Moreover it adds a new private method into LazyAttributeMixin class: _check_supported_versions which is responsible for veryfing if an instantiated class for the API is supported in the target's device tmos. Files affected: f5\bigip\__init__.py f5\bigip\mixins.py f5\bigip\resource.py f5\bigip\tm\cm\trust.py f5\bigip\tm\ltm\profile.py
Issues: Fixes #<issueid> Problem: Analysis: Tests:
Issues: Fixes #<issueid> Problem: Analysis: Tests:
Issues: Fixes #<issueid> Problem: Analysis: Tests:
Contributor
Author
|
Well... I guess I can land this one, since it's @wojtek0806 's. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has @wojtek0806 's multiversion feature, plus a few enhancements to unittests to make them pass.