Adds GTM iRule api support#496
Conversation
caphrim007
force-pushed
the
add-gtm-irule-support
branch
2 times, most recently
from
da24cf1 to
35db857
Compare
|
Looks good to merge, not sure if i got merge rights tho, leaving for @zancas to merge |
|
I have pulled this PR, and while this is unrelated to this PR, it looks like the 4 sec timeouts are causing some false positives when testing against hardware units: and: Can you tell me if they fail for you locally too? I added those previously due to Jenkins failures. For me reducing those to 2 sec fixes problem, but I do not want to cause Jenkins fails with that change |
|
@wojtek0806 was that second comment meant for a different PR? |
|
@caphrim007 I meant this for this PR, i just wanna check if failover passes on your end, if not then we can reduce the timeout values and kill 2 birds with 1 stone, rather than raising second PR just to fix the timing in the test |
|
@wojtek0806 I had no issues running the tests on this feature. |
|
|
||
| class TestCreate(object): | ||
| def test_create_two(self, fakeicontrolsession): | ||
| b = BigIP('192.168.1.1', 'admin', 'admin') |
There was a problem hiding this comment.
Please update to use the new root ManagementRoot
There was a problem hiding this comment.
Is there an example? All the existing tests use BigIP
There was a problem hiding this comment.
I'm doing something like that in clustering: https://github.com/F5Networks/f5-common-python/blob/development/f5/multi_device/cluster/test/test_cluster_manager.py
Issues: Fixes F5Networks#494 Problem: The SDK currently does not support the GTM iRule API Analysis: This patch adds support and tests for to the SDK for the GTM iRule API Tests: * test/functional/tm/gtm/test_rule.py * f5/tm/gtm/test/test_rule.py
caphrim007
force-pushed
the
add-gtm-irule-support
branch
from
35db857 to
4b9f576
Compare
|
@pjbreaux PR updated |
|
Well this is all just delectable. If Jenkins passes. I'll merge. |
|
Now was this prioritized for a specific milestone? (I should have asked this first) |
|
@pjbreaux no, it was just something that came up recently when I was doing ansible work |
3 participants
@wojtek0806 @zancas
Fixes #494
What's this change do?
This patch adds support and tests for to the SDK for the GTM iRule API
Where should the reviewer start?
Any background context?
The SDK currently does not support the GTM iRule API.