Bugfix.user create 11 5 4#563
Merged
caphrim007 merged 1 commit intoF5Networks:developmentfrom Aug 1, 2016
Merged
Conversation
test_user.py suite Issues: Fixes F5Networks#562 Problem: The test in test/functional/auth/test_user fails due to the fact that in 11.5.4, the field partitionAccess is returned as a unicode, yet in 11.6 and greater, it is a dict. This just requires a test fixup for now. Analysis: Created a separate test for 11.5.4 and lower versions. The original failing test is now skipped if the release version given to pytest is lower than 11.6.0. Tests: Functional tests for test_user.py now pass
pjbreaux
force-pushed
the
bugfix.user_create_11_5_4
branch
from
76d439a to
9fd40bd
Compare
Contributor
|
tested on 11.5.4 hf1. works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zancas
What's this change do?
Fixes a test issue that is only apparent when testing against 11.5.4. The create user test was expecting a field, partitionAccess, to be a dict, but it is a string in 11.5.4.
Any background context?
We are fixing up failures that occur when testing against an 11.5.4 device. When you run pytest, you must include the --release option, so the appropriate test will be skipped based on the version given.
Where should the reviewer start?
Only a test fix.