Fixing functional test issues in test/functional/tm/ltm/test_policy.py#568
Merged
zancas merged 3 commits intoF5Networks:developmentfrom Jul 26, 2016
Merged
Conversation
Contributor
|
which bigip versions were showing the failure? all of them? |
Contributor
Author
|
11.5.4 |
Contributor
|
checking |
| after_snapshot = register_device(mgmt_root) | ||
| diff = set(after_snapshot) - set(before_snapshot) | ||
| for item in diff: | ||
| after_snapshot[item].delete() |
Contributor
Author
There was a problem hiding this comment.
Add try except around this statement.
pjbreaux
force-pushed
the
bugfix.test_policy_11_5_4
branch
from
e200d08 to
effa22c
Compare
Contributor
Author
added 3 commits
July 21, 2016 14:14
test/functional/tm/ltm/test_policy.py tests produce errors Issues: Fixes F5Networks#567 Problem: During test teardown, an attempt is made to delete the policies that are not a part of the built-ins. The built-ins have changed between versions of TMOS. We should snapshot the get_collection call and use that pre-test snapshot to delete all those policies created by the tests. Analysis: Implemented a module-level pytest fixture which snapshots the device before and after the test. The diff between those snapshots is used to remove objects created by the tests. Tests: test_policy tests now pass against 11.5.4 and 11.6.0
does not come back online Issues: Fixes F5Networks#553 Problem: If the tests failed in the middle of bringing the device to offline, the device remains in that state. There are also sleeps in these tests, which should be removed. Analysis: Implemented a pollster to check what state the device is in and created a teardown that assures the device is active before leaving the test. Tests: All these tests pass against 11.5.4 and 11.6.0
pjbreaux
force-pushed
the
bugfix.test_policy_11_5_4
branch
from
effa22c to
c8e058e
Compare
| new_instance._activate_URI(new_instance.selfLink) | ||
| return new_instance | ||
|
|
||
| def _reduce_boolean_pair(self, config_dict, key1, key2): |
Contributor
Author
There was a problem hiding this comment.
@zancas: Moved this method up to ResourceBase because the class Failover is an UnnamedResource, which inherits from ResourceBase, not resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zancas
Don't merge until #558 has been merged!
What's this change do?
Implemented a module-level pytest fixture which snapshots the device
before and after the test. The diff between those snapshots is used to
remove objects created by the tests.
Any background context?
During test teardown, an attempt is made to delete the policies that are
not a part of the built-ins. The built-ins have changed between versions
of TMOS. We should snapshot the get_collection call and use that
pre-test snapshot to delete all those policies created by the tests.
Where should the reviewer start?
conftest.py change, then the changes in the test_policy.py file