Bugfix.failover tests 11 5 4#570
Merged
caphrim007 merged 2 commits intoF5Networks:developmentfrom Aug 1, 2016
Merged
Conversation
pjbreaux
force-pushed
the
bugfix.failover_tests_11_5_4
branch
from
61a56bb to
2ab640c
Compare
added 2 commits
July 26, 2016 14:05
setup Issues: Fixes F5Networks#555 Problem: We have 8 test failures against 11.5.4 and all but one have the same signature: Found unexpected json pair at module Analysis: After further inspection, it's simply that these collections do not exist on the 11.5.4 device. Added minimum tmos version to these collections, so they will not be instantiated by a user. Added some tests to ensure that the correct exception is raised if a user does try to instantiate one of these collections. Tests: All profile tests are passing on 11.5.4 and 11.6.0
pjbreaux
force-pushed
the
bugfix.failover_tests_11_5_4
branch
from
bdca55f to
5d8be4b
Compare
Contributor
Author
|
@caphrim007: I've updated this PR with you as the assignee. Let me know if you have the bandwidth to look at it. All changes are for 11.5.4 compatibility. |
Contributor
Author
|
I will address your slack comments. Thanks! |
Contributor
|
after those are addressed, it should be ready to merge, but i will test again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zancas
Close #558 before this one!
What's this change do?
Updates failover resource to use new ReduceBooleanPairToTrueMixin to reduce online and offline in that resource and remove local logic that was doing the same thing as the mixin. Also fixed the tests for this resource to teardown properly, leaving the device in an online state.
Any background context?
During functional testing in 11.5.4 device goes to forced offline and does not come back online. We also needed to remove sleeps from these tests to make them more event driven.
Where should the reviewer start?
Tests, then resource changes.