Fix the sshd tests#588
Conversation
|
@pjbreaux the errors in this pr are related to the profiles thing that you're in the process of fixing |
|
Yes, they will likely be taken care of by my PR. We can merge yours first. |
|
But travis is failing as well. |
964131a to
9bf51b9
Compare
|
fixes incoming |
|
@pjbreaux ok travis is fixed. i think the remaining issues are the profiles thing you're handling |
|
Does the above represent a run against 11.5.4 and 11.6.0? |
|
11.5.4 |
|
the 11.5.4 is the first set run. if it fails then it doesnt make it to 11.6.0 |
|
Before we merge, can you rebase then revert the skip in test/functional/tm/sys/test_sshd.py. The change I made to skip was: V11_SUPPORTED = ['11.6.0', '11.6.1'] |
|
@caphrim007: also, we'll wait until we close PR #593 and PR #592 |
|
@pjbreaux does it not work in 11.6.0? |
9bf51b9 to
ffa3ffa
Compare
|
oh jeez, what did I do to my branch :-P |
|
I saw the commits first, I typed out a comment, then I saw your comment. |
3837a9c to
2c68a7f
Compare
2c68a7f to
aaaab98
Compare
aaaab98 to
7906d64
Compare
Issues: Fixes F5Networks#587 Problem: The sshd tests have been broken since the introduction (I think) of the boolean reducing code. Analysis: This changes the tests to not use deepcopy and instead just select two distinct resources from the bigip Tests: existing sshd functional tests
7906d64 to
650bc60
Compare
@pjbreaux
Issues:
Fixes #587
Problem:
The sshd tests have been broken since the introduction (I think) of the
boolean reducing code.
Analysis:
This changes the tests to not use deepcopy and instead just select
two distinct resources from the bigip
Tests:
existing sshd functional tests