Skip to content

Fix the sshd tests#588

Merged
zancas merged 1 commit intoF5Networks:developmentfrom
caphrim007:bugfix.sshd-tests-failing
Aug 2, 2016
Merged

Fix the sshd tests#588
zancas merged 1 commit intoF5Networks:developmentfrom
caphrim007:bugfix.sshd-tests-failing

Conversation

@caphrim007
Copy link
Copy Markdown
Contributor

@pjbreaux

Issues:
Fixes #587

Problem:
The sshd tests have been broken since the introduction (I think) of the
boolean reducing code.

Analysis:
This changes the tests to not use deepcopy and instead just select
two distinct resources from the bigip

Tests:
existing sshd functional tests

@caphrim007
Copy link
Copy Markdown
Contributor Author

@pjbreaux the errors in this pr are related to the profiles thing that you're in the process of fixing

@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 1, 2016

Yes, they will likely be taken care of by my PR. We can merge yours first.

@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 1, 2016

But travis is failing as well.

@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 1, 2016

@caphrim007 caphrim007 force-pushed the bugfix.sshd-tests-failing branch from 964131a to 9bf51b9 Compare August 1, 2016 20:28
@caphrim007
Copy link
Copy Markdown
Contributor Author

fixes incoming

@caphrim007
Copy link
Copy Markdown
Contributor Author

@pjbreaux ok travis is fixed. i think the remaining issues are the profiles thing you're handling

@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 1, 2016

Does the above represent a run against 11.5.4 and 11.6.0?

@caphrim007
Copy link
Copy Markdown
Contributor Author

11.5.4

@caphrim007
Copy link
Copy Markdown
Contributor Author

the 11.5.4 is the first set run. if it fails then it doesnt make it to 11.6.0

@pjbreaux pjbreaux self-assigned this Aug 2, 2016
@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 2, 2016

Before we merge, can you rebase then revert the skip in test/functional/tm/sys/test_sshd.py. The change I made to skip was:

V11_SUPPORTED = ['11.6.0', '11.6.1']
Changed to...
V11_SUPPORTED = ['11.6.2', '11.6.1']

@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 2, 2016

@caphrim007: also, we'll wait until we close PR #593 and PR #592

@caphrim007
Copy link
Copy Markdown
Contributor Author

@pjbreaux does it not work in 11.6.0?

@caphrim007 caphrim007 force-pushed the bugfix.sshd-tests-failing branch from 9bf51b9 to ffa3ffa Compare August 2, 2016 16:16
@caphrim007
Copy link
Copy Markdown
Contributor Author

oh jeez, what did I do to my branch :-P

@pjbreaux
Copy link
Copy Markdown
Contributor

pjbreaux commented Aug 2, 2016

I saw the commits first, I typed out a comment, then I saw your comment.

@caphrim007 caphrim007 force-pushed the bugfix.sshd-tests-failing branch 13 times, most recently from 3837a9c to 2c68a7f Compare August 2, 2016 20:00
@caphrim007 caphrim007 force-pushed the bugfix.sshd-tests-failing branch from 2c68a7f to aaaab98 Compare August 2, 2016 20:28
@caphrim007 caphrim007 force-pushed the bugfix.sshd-tests-failing branch from aaaab98 to 7906d64 Compare August 2, 2016 20:33
Issues:
Fixes F5Networks#587

Problem:
The sshd tests have been broken since the introduction (I think) of the
boolean reducing code.

Analysis:
This changes the tests to not use deepcopy and instead just select
two distinct resources from the bigip

Tests:
existing sshd functional tests
@caphrim007 caphrim007 force-pushed the bugfix.sshd-tests-failing branch from 7906d64 to 650bc60 Compare August 2, 2016 20:40
@caphrim007
Copy link
Copy Markdown
Contributor Author

@zancas @pjbreaux with skipping that module, these tests now pass. merge when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants