Feature.modify 609#612
Merged
zancas merged 9 commits intoF5Networks:developmentfrom Aug 10, 2016
Merged
Conversation
Contributor
Author
|
@zancas: check out the failure in jenkins for the 11.6.0 run. This test doesn't fail for me locally, when testing against 12.0.0 |
Contributor
|
Is there still a 11.6.0 Jenkins fail? This PR shows "All checks have passed". |
added 3 commits
August 9, 2016 19:47
Issues: Fixes F5Networks#609 Problem: Instead of puting the whole configuration object in a request to the server, modify will only submit the explicitly specified parameters in its kwargs, in a patch request to the server. This feature should be implemented after F5Networks#608. Analysis: Added modify in ResourceBase, and created a couple of non-public helper functions to make common usage among _update and _modify. Tests: Unit tests pass, but functionals still need to be written. Only one functional test exists currently.
Contributor
|
@pjbreaux I ran the tests locally, 11.6.0:
The skips are mostly I have some unittests on my version of the feature branch:
So, can you either rebase on top of it, or otherwise get it to be the thing this PR is to include it? |
pjbreaux
force-pushed
the
feature.modify_609
branch
from
2b25631 to
d277efc
Compare
Contributor
Author
|
Rebased and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zancas
What's this change do?
Implements the modify method, which is a requests.patch call to exclusively update that which a user specifies by sending in the keyword arguments. The arguments are those that are updated, and nothing more.
Any background context?
Where should the reviewer start?
Start at the unit and functional tests, then move on to resource.py changes.