Adding GTM wideips - Branched out of Servers PR, merge this after PR(#673)#674
Merged
caphrim007 merged 2 commits intoF5Networks:developmentfrom Sep 9, 2016
Conversation
Problem: GTM server endpoint was missing from the SDK. This is a first of a series of PRs meant to introduce the GTM pools to the SDK Analysis: Server endpoint was added as it was a dependency for GTM pools Tests: Flake8 Functional Tests Unit Tests Files Added/Changed: f5-common-python/f5/bigip/tm/gtm/init.py f5-common-python/f5/bigip/tm/gtm/server.py f5-common-python/f5/bigip/tm/gtm/test/test.server.py f5-common-python/test/functional/tm/gtm/test_server.py
Problem: GTM WideIP endpoint was missing from the SDK. This is a first of a series of PRs meant to introduce the GTM pools to the SDK Analysis: WideIP endpoint was added as it was a dependency for GTM pools Tests: Flake8 Functional Tests Unit Tests Files Added/Changed: f5-common-python/f5/bigip/tm/gtm/init.py f5-common-python/f5/bigip/tm/gtm/wideip.py f5-common-python/f5/bigip/tm/gtm/test/test_wideip.py f5-common-python/test/functional/tm/gtm/test_wideip.py
| Virtual_Servers} | ||
|
|
||
|
|
||
| class Virtual_Servers(Resource): |
Contributor
There was a problem hiding this comment.
I realize I let this slide in the last PR, but we have a precedent in the sys/snmp code whereby the resource being operated on in singular. So methinks we should continue that here and fix the other PR (or fix both of these in a new PR).
See here
https://github.com/F5Networks/f5-common-python/blob/development/f5/bigip/tm/sys/snmp.py#L64
Contributor
|
aside from the plural -> singular, lgtm. singular can be fixed for both this and #673 in a later pr |
Contributor
Author
|
ok can you open issue for that and assign to me :) ? |
|
I've seen it both ways.. this PR is in alignment with existing ltm/pool/members |
caphrim007
added a commit
that referenced
this pull request
Sep 9, 2016
…s_pr Adding GTM pools - branched out ofr PR(#674), merge this last
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #633
Problem:
GTM WideIP endpoint was missing from the SDK. This is a first of a series of PRs meant to introduce the GTM pools to the SDK
Analysis:
WideIP endpoint was added as it was a dependency for GTM pools
Tests:
Flake8
Functional Tests
Unit Tests
Files Added/Changed:
f5-common-python/f5/bigip/tm/gtm/init.py
f5-common-python/f5/bigip/tm/gtm/wideip.py
f5-common-python/f5/bigip/tm/gtm/test/test_wideip.py
f5-common-python/test/functional/tm/gtm/test_wideip.py