Adding tm/util/unix-rm#678
Merged
caphrim007 merged 3 commits intoF5Networks:developmentfrom Sep 12, 2016
Merged
Conversation
…x-rm up first. Updated Files: f5/bigip/tm/__init__.py Added Files: f5/bigip/tm/util/__init__.py f5/bigip/tm/util/Unix_Rm.py f5/bigip/tm/test/test_unix_rm.py test/functional/tm/util/__init__.py (empty file) test/functional/tm/util/test_unix_rm.py
Author
|
successful tests on first try...what?!? @caphrim007 or @zancas, this is ready for review. Happy to answer any questions. |
Author
|
(lion king mood music) Can you feel...the merge tonight, it is where we are.... :) Have a nice weekend all. |
Contributor
|
@jasonrahm would you add tests to cover the red lines in this coverage report? https://coveralls.io/builds/7825345/source?filename=f5%2Fbigip%2Ftm%2Futil%2FUnix_Rm.py |
… test coverage f5/bigip/tm/util/Unix_Rm.py - removed unnecessary return statement test/functional/tm/util/test_unix_rm.py - added functional test to cover failure case
Contributor
|
hakuna matata, what a wonder PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #538 - Feature introduction for utility commands; unix-rm up first.
Updated Files:
f5/bigip/tm/init.py
Added Files:
f5/bigip/tm/util/init.py
f5/bigip/tm/util/Unix_Rm.py
f5/bigip/tm/test/test_unix_rm.py
test/functional/tm/util/init.py (empty file)
test/functional/tm/util/test_unix_rm.py