Skip to content

Improved water settings#52

Merged
BlackYps merged 9 commits intomasterfrom
water-settings
Jan 28, 2025
Merged

Improved water settings#52
BlackYps merged 9 commits intomasterfrom
water-settings

Conversation

@BlackYps
Copy link
Copy Markdown

@BlackYps BlackYps commented Jan 20, 2025

  • Remove unused water options
  • Add toggle to copy sun color and angle from light settings to get fitting sun reflections on the water
  • Add toggle to switch to advanced water (this will recalculate the light settings in the background)
  • Remove clamping from RGB values
  • Change sun angle terminology in light settings
  • Various other minor UI improvements in the water and light settings
  • Fix water coloration bleeding up on shores
  • Add texture paths for water ramp and skycube
    grafik
    grafik

Closes #36
Closes #37

@BlackYps BlackYps changed the title Water settings Improved water settings Jan 20, 2025
@sting-2
Copy link
Copy Markdown

sting-2 commented Jan 28, 2025

I tested this on a couple of maps I know have non-standard water settings. It looks good to me. The sky reflection is much stronger in the editor than in-game. Any idea if it's feasible to get that more closely aligned?

0.8 -> in-game
image

this PR -> in-game
image

@BlackYps
Copy link
Copy Markdown
Author

Did you observe this on any other maps? The issue seems to be that the editor and the game interpret the textures differently. Normally the cubemaps are stored with the metadata info that it is a cubemap, your custom texture does not do that. You can see the difference when loading the textures in paint.net:
grafik
Unity actually throws an error when loading your texture.
UnityEngine.UnityException: LoadRawTextureData: not enough data provided (will result in overread). This results in a white texture and the resulting intense reflections

@BlackYps
Copy link
Copy Markdown
Author

I also added the texture paths for the water ramp and sky cube textures. They don't come with a file browser yet, but at least you can type in the path now.

@BlackYps BlackYps merged commit b445d80 into master Jan 28, 2025
@BlackYps BlackYps deleted the water-settings branch January 28, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide not physically accurate settings behind a toggle Add button to set shadowcolor to 0

2 participants