Add map_play_count trigger to record map plays#272
Merged
Brutus5000 merged 9 commits intodevelopfrom May 9, 2021
Merged
Conversation
Member
|
Table_map_features should be removed (It's not used by any service) and the column should go into map_version. |
Member
Author
|
Just so I am clear should that recomputation be a part of this migration |
Sheikah45
force-pushed
the
bugfix/map-play-count
branch
from
ab2e3e6 to
88408d6
Compare
Member
Author
|
Hmm actually the api does use table_map_features it just calls it map_statistics not sure how that works though |
Sheikah45
force-pushed
the
bugfix/map-play-count
branch
2 times, most recently
from
5cf8c1a to
37db340
Compare
Member
Author
|
Reviews please? |
…n to map_version and map tables
Sheikah45
force-pushed
the
bugfix/map-play-count
branch
from
4a602e8 to
25d4293
Compare
Brutus5000
requested changes
Apr 19, 2021
Member
Author
|
Was there anything else we wanted to change here? |
Brutus5000
approved these changes
Apr 27, 2021
Brutus5000
approved these changes
May 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
Fixes #273