Hotfix/1043 #1077
Closed
Hotfix/1043 #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new build restriction set that stop factories from building (not upgrading) factories. This is a workaround to fix FAForever#1043 until engymod can be fixed properly.
Member
|
Confirmed the first, can't imagine any problem with the second. Merging. |
Member
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new build restriction set that stop factories from building
(not upgrading) factories.
This is a workaround to fix #1043 until engymod can be fixed properly.
While we're at it, I also removed a useless CheckBuildRestriction override.
Please check that it doesn't mess with anything.
To test:
[x] There are no units with the
Factoryprimary category built fromFactoryUnitfactories[ ] Removal of the CheckBuildRestriction function from
ConstructionUnitdoesn't screw something up[x] Aircraft carriers still work as expected, tested with Cybran Carrier
[x] Megalith eggs still work as expected