Skip to content

Display the Minus hotkey label correctly#7043

Merged
lL1l1 merged 2 commits intoFAForever:developfrom
NoryGit:minus_hotkeylabel
Feb 20, 2026
Merged

Display the Minus hotkey label correctly#7043
lL1l1 merged 2 commits intoFAForever:developfrom
NoryGit:minus_hotkeylabel

Conversation

@NoryGit
Copy link
Contributor

@NoryGit NoryGit commented Feb 19, 2026

Description of the proposed changes

The 'Minus' key was missing from the signs table in hotkeylabels.lua, causing the raw string "Minus" to be used. Since hotkey labels only support strings up to 3 characters, this triggered a Not showing label for keybind Minus due to length warning and prevented the label from showing.

Mapping "Minus" to "-" in the signs table resolves the issue.

Checklist

- [ ] Changes are annotated, including comments where useful

Summary by CodeRabbit

  • New Features
    • Added support for the Minus key in hotkey labels, enabling proper display of keyboard shortcuts using the Minus key.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

📝 Walkthrough

Walkthrough

A new mapping is added to the signs table in the hotkey labels module, linking the Minus key to its string representation "-", expanding the available key symbols for hotkey label rendering.

Changes

Cohort / File(s) Summary
Hotkey Label Mapping
lua/keymap/hotkeylabels.lua
Added Minus key mapping to the signs table, mapping "Minus" to the "-" string representation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A minus key hopped into view,
With dashes now shiny and new,
The rabbit did sing, with a hop and a swing,
For mappings that sparkle in blue! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description clearly explains the issue and solution, but omits required checklist items and reviewer assignment. Add 2-3 reviewer assignments from the approved list per contributing guidelines and ensure all checklist items are addressed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: adding a mapping for the Minus key to display correctly as a dash in hotkey labels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

Image

@lL1l1 lL1l1 merged commit 7b602b0 into FAForever:develop Feb 20, 2026
5 checks passed
@NoryGit NoryGit deleted the minus_hotkeylabel branch February 20, 2026 13:18
relent0r pushed a commit to relent0r/fa that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants