Display the Minus hotkey label correctly#7043
Merged
lL1l1 merged 2 commits intoFAForever:developfrom Feb 20, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughA new mapping is added to the signs table in the hotkey labels module, linking the Minus key to its string representation "-", expanding the available key symbols for hotkey label rendering. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
relent0r
pushed a commit
to relent0r/fa
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of the proposed changes
The 'Minus' key was missing from the signs table in
hotkeylabels.lua, causing the raw string "Minus" to be used. Since hotkey labels only support strings up to 3 characters, this triggered aNot showing label for keybind Minus due to lengthwarning and prevented the label from showing.Mapping "Minus" to "-" in the signs table resolves the issue.
Checklist
- [ ] Changes are annotated, including comments where usefulSummary by CodeRabbit