Skip to content

Give Cybran Carrier impact effects for its increased splash#7109

Merged
Rhaelya merged 5 commits into
FAForever:developfrom
lL1l1:cyb-carrier-splash-vfx
May 9, 2026
Merged

Give Cybran Carrier impact effects for its increased splash#7109
Rhaelya merged 5 commits into
FAForever:developfrom
lL1l1:cyb-carrier-splash-vfx

Conversation

@lL1l1
Copy link
Copy Markdown
Contributor

@lL1l1 lL1l1 commented May 9, 2026

Description of the proposed changes

Gives Cybran carrier the impact effect of the SAM since it now has splash damage from #7055.
The guns are changed to fire 1 projectile per fire to reduce the brightness of the new effect since 4 projectiles (from 4 guns) was overwhelmingly bright.

I considered giving it the flak impact effect but that effect matches worse with the damage radius of the weapon.

Testing done on the proposed changes

Visual inspection firing at some spy planes.

Cyb.carrier.impact.effect.mp4

Checklist

- [ ] Changes are annotated, including comments where useful

Summary by CodeRabbit

  • Balance Changes

    • Anti-air "Electron Autocannon" weapons now deliver significantly increased damage output against aerial targets
    • Projectile effects updated with new visual scaling parameters and impact templates
  • Chores

    • Changelog updated to reflect balance adjustments

@lL1l1 lL1l1 added the area: graphics Anything Related to the Game Graphics label May 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Review Change Stack

Warning

Rate limit exceeded

@lL1l1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: acf4ebf4-b2b1-4964-9f4e-a04ab4b1faf3

📥 Commits

Reviewing files that changed from the base of the PR and between 03ece2f and db238e4.

📒 Files selected for processing (1)
  • changelog/snippets/balance.7055.md
📝 Walkthrough

Walkthrough

This PR balances the URS0303 unit's anti-air weapon capabilities by quadrupling damage output from 20 to 80 per hit across all four Electron Autocannon hardpoints, restructuring their firing patterns through granular RackBones configuration, and configuring the projectile effects to scale air-unit impacts appropriately.

Changes

Anti-Air Weapon Balancing

Layer / File(s) Summary
Projectile Effects Configuration
projectiles/CAAAutocannon03/CAAAutocannon03_script.lua
CAAAutocannon03 projectile class now imports EffectTemplate and configures FxAirUnitHitScale = 1.5 and FxImpactAirUnit = EffectTemplate.CNanoDartUnitHit01 for air-unit impacts.
Weapon Damage Increases
units/URS0303/URS0303_unit.bp
All four Electron Autocannon hardpoints (AAGun01AAGun04) have Damage increased from 20 to 80.
Weapon Rack Restructuring
units/URS0303/URS0303_unit.bp
For each AA gun, RackBones is split into separate blocks per muzzle bone (Front_Right_AA_Muzzle_*, Back_Right_AA_Muzzle_*, Back_Left_AA_Muzzle_*, Front_Left_AA_Muzzle_*) while retaining the same RackBone target.
Changelog Documentation
changelog/snippets/balance.7055.md
Header updated to reference both #7055 and #7109.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • FAForever/fa#7055: Related balance changes to the same URS0303 AA weapons, adding DamageRadius fields while this PR adjusts Damage values and firing patterns.

Suggested labels

area: balance, area: sim

Suggested reviewers

  • BlackYps
  • Basilisk3
  • Rhaelya

Poem

🐰 Four cannons roar with might anew,
From twenty damage up to eighty too!
The rabbit fires from every muzzle bone,
With impact FX that shakes the zone—
AA balance blooms, the damage done!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding impact effects to the Cybran Carrier for its increased splash damage. It is concise, specific, and clearly summarizes the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description includes a clear explanation of changes, testing performed with visual evidence, and checklist items completed. However, it does not explicitly reference the issue number(s) being addressed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lL1l1 lL1l1 marked this pull request as ready for review May 9, 2026 00:29
Copy link
Copy Markdown
Contributor

@Rhaelya Rhaelya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as intended.

@Rhaelya Rhaelya merged commit a533418 into FAForever:develop May 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graphics Anything Related to the Game Graphics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants