Skip to content

Exclude user from jsonapi response for account links#634

Merged
Sheikah45 merged 1 commit intodevelopfrom
bugfix/accountlink-exclude-user-elide
Jul 27, 2022
Merged

Exclude user from jsonapi response for account links#634
Sheikah45 merged 1 commit intodevelopfrom
bugfix/accountlink-exclude-user-elide

Conversation

@Sheikah45
Copy link
Member

@Sheikah45 Sheikah45 commented Jul 27, 2022

User is not included in elide so leads to an NPE when accountLinks are included in any response

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #634 (288dd30) into develop (f91b4ed) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #634      +/-   ##
=============================================
- Coverage      75.63%   75.61%   -0.03%     
+ Complexity      1155     1154       -1     
=============================================
  Files            244      244              
  Lines           3674     3674              
  Branches         232      232              
=============================================
- Hits            2779     2778       -1     
- Misses           798      799       +1     
  Partials          97       97              
Impacted Files Coverage Δ
...ava/com/faforever/api/data/domain/AccountLink.java 90.00% <ø> (-10.00%) ⬇️
...main/java/com/faforever/api/data/domain/Login.java 85.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91b4ed...288dd30. Read the comment docs.

@Sheikah45 Sheikah45 changed the title exclude user from jsonapi response for account links Exclude user from jsonapi response for account links Jul 27, 2022
@Sheikah45 Sheikah45 merged commit 123aacc into develop Jul 27, 2022
@Sheikah45 Sheikah45 deleted the bugfix/accountlink-exclude-user-elide branch July 27, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant