Skip to content

Conversation

@Brutus5000
Copy link
Member

@Sheikah45 I'd love to see a cross-check whether we cover all "client startup calls" correctly

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #705 (b8bb530) into develop (2d2d8c5) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #705      +/-   ##
=============================================
- Coverage      76.18%   76.12%   -0.07%     
  Complexity      1166     1166              
=============================================
  Files            245      245              
  Lines           3746     3749       +3     
  Branches         233      233              
=============================================
  Hits            2854     2854              
- Misses           794      797       +3     
  Partials          98       98              
Impacted Files Coverage Δ
...ain/java/com/faforever/api/config/CacheConfig.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2d8c5...b8bb530. Read the comment docs.

@Sheikah45
Copy link
Member

What do you mean by startup calls?

The only call the client makes on startup is to /me.

The only other critical one is the featured mods and coturn endpoints so people can start a game

@Brutus5000
Copy link
Member Author

Avatars and/or players or ratings after joining chat? Maps / mods that are in the current game list?

@Sheikah45
Copy link
Member

On that basis I think the ones I don't understand are the avatar assignment. As that is going to be different for everyone, it is also an infrequent call so may not even be worth caching. And then also the leaderboard rating I am not sure of either.

The map statistics isn't used by the client either I believe.

@Brutus5000 Brutus5000 force-pushed the bugfix/prevent-caching-oom branch from abee8f4 to b8bb530 Compare February 11, 2023 21:44
@Brutus5000 Brutus5000 merged commit bc7f77b into develop Feb 12, 2023
@Brutus5000 Brutus5000 deleted the bugfix/prevent-caching-oom branch February 12, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants