Skip to content

Conversation

@bukajsytlos
Copy link
Member

Closes #652 Add replay rating to the replay search

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #719 (0490882) into develop (f175f2f) will increase coverage by 0.08%.
The diff coverage is 25.00%.

❗ Current head 0490882 differs from pull request most recent head ea6bf82. Consider uploading reports for the commit ea6bf82 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #719      +/-   ##
=============================================
+ Coverage      76.49%   76.57%   +0.08%     
- Complexity      1174     1179       +5     
=============================================
  Files            244      245       +1     
  Lines           3731     3744      +13     
  Branches         234      233       -1     
=============================================
+ Hits            2854     2867      +13     
  Misses           779      779              
  Partials          98       98              
Impacted Files Coverage Δ
...m/faforever/api/data/domain/MapReviewsSummary.java 0.00% <0.00%> (ø)
...m/faforever/api/data/domain/ModReviewsSummary.java 0.00% <0.00%> (ø)
...ever/api/data/domain/ModVersionReviewsSummary.java 0.00% <0.00%> (ø)
.../faforever/api/data/domain/GameReviewsSummary.java 100.00% <100.00%> (+100.00%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111383e...ea6bf82. Read the comment docs.

@Sheikah45
Copy link
Member

How intensive is the formula calculation? Does it perform that in SQL?

@bukajsytlos
Copy link
Member Author

yes it is done on DB side, but now that I think of it, we should probably make it "real" virtual column in DB so that it can be indexed

Brutus5000
Brutus5000 previously approved these changes Mar 8, 2023
@bukajsytlos bukajsytlos force-pushed the feature/#652-reviews-score-filtering branch 2 times, most recently from 7ed4719 to 9a572f7 Compare March 19, 2023 16:44
@bukajsytlos bukajsytlos force-pushed the feature/#652-reviews-score-filtering branch from 9a572f7 to 757e34f Compare May 8, 2023 19:35
@bukajsytlos bukajsytlos force-pushed the feature/#652-reviews-score-filtering branch from 757e34f to ea6bf82 Compare May 31, 2023 08:16
@Brutus5000 Brutus5000 merged commit 5b8e863 into develop May 31, 2023
@Brutus5000 Brutus5000 deleted the feature/#652-reviews-score-filtering branch May 31, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add replay rating to the replay search

4 participants