Skip to content

Conversation

@Sheikah45
Copy link
Member

No description provided.

@Sheikah45 Sheikah45 requested a review from Brutus5000 April 16, 2023 02:08
@Sheikah45 Sheikah45 force-pushed the bugfix/no-coturn-key branch from b53f3a7 to 0c883ff Compare April 16, 2023 02:24
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #731 (9e7d709) into develop (2092e50) will increase coverage by 0.29%.
The diff coverage is 96.42%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #731      +/-   ##
=============================================
+ Coverage      76.20%   76.49%   +0.29%     
- Complexity      1161     1174      +13     
=============================================
  Files            243      244       +1     
  Lines           3706     3731      +25     
  Branches         233      234       +1     
=============================================
+ Hits            2824     2854      +30     
+ Misses           785      779       -6     
- Partials          97       98       +1     
Impacted Files Coverage Δ
src/main/java/com/faforever/api/error/Error.java 100.00% <ø> (ø)
...com/faforever/api/coturn/CoturnServerEnricher.java 95.00% <95.00%> (ø)
...va/com/faforever/api/data/domain/CoturnServer.java 100.00% <100.00%> (+83.33%) ⬆️
...c/main/java/com/faforever/api/error/ErrorCode.java 99.13% <100.00%> (+<0.01%) ⬆️
...ever/api/featuredmods/FeaturedModFileEnricher.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2092e50...9e7d709. Read the comment docs.

@Sheikah45 Sheikah45 force-pushed the bugfix/no-coturn-key branch from c34e3ab to 4294fc5 Compare May 28, 2023 15:41
@Brutus5000 Brutus5000 merged commit f175f2f into develop May 30, 2023
@Brutus5000 Brutus5000 deleted the bugfix/no-coturn-key branch May 30, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants