Skip to content

Conversation

@bukajsytlos
Copy link
Member

Closes #739 Elide 7.0.0-pr4

Something changed on permission evaluation. When creating/updating one to many relation data, elide checks for read permission on given related entities (ids)

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #741 (fcd9e1c) into develop (be88991) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #741      +/-   ##
=============================================
- Coverage      76.31%   76.20%   -0.11%     
+ Complexity      1166     1161       -5     
=============================================
  Files            245      243       -2     
  Lines           3740     3706      -34     
  Branches         233      233              
=============================================
- Hits            2854     2824      -30     
+ Misses           788      785       -3     
+ Partials          98       97       -1     
Impacted Files Coverage Δ
...main/java/com/faforever/api/FafApiApplication.java 33.33% <ø> (ø)
...a/com/faforever/api/config/FafDatastoreConfig.java 100.00% <100.00%> (ø)
...om/faforever/api/config/LeagueDatastoreConfig.java 100.00% <100.00%> (ø)
.../java/com/faforever/api/data/domain/UserGroup.java 100.00% <100.00%> (ø)
...n/java/com/faforever/api/security/AuditAspect.java 89.47% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a16aa8...fcd9e1c. Read the comment docs.

@bukajsytlos
Copy link
Member Author

seems like it is a feature (fixed bug) yahoo/elide#558

@Brutus5000 Brutus5000 merged commit 6eaf11d into develop May 22, 2023
@Brutus5000 Brutus5000 deleted the feature/#739-elide-7-pr4 branch May 22, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elide 7.0.0-pr4

3 participants