Skip to content

add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key#309

Merged
Sheikah45 merged 4 commits intodevelopfrom
Sheikah45-patch-1
May 6, 2026
Merged

add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key#309
Sheikah45 merged 4 commits intodevelopfrom
Sheikah45-patch-1

Conversation

@Sheikah45
Copy link
Copy Markdown
Member

@Sheikah45 Sheikah45 commented May 6, 2026

Summary by CodeRabbit

  • Chores
    • Updated service proxy configuration to apply production-specific overrides for enhanced environment alignment.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

📝 Walkthrough

Walkthrough

The Tiltfile is updated to pass production-specific Helm values to the faf-icebreaker local service proxy by adding additional_values=["apps/faf-icebreaker/values-prod.yaml"] to the proxy_local_service_if_set invocation.

Changes

faf-icebreaker Helm Values Configuration

Layer / File(s) Summary
Configuration Update
Tiltfile
faf-icebreaker service proxy now includes additional_values=["apps/faf-icebreaker/values-prod.yaml"] to apply production-specific Helm value overrides alongside the existing config patch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 hops excitedly
A Tiltfile tweak, so small yet bright,
faf-icebreaker's prod values take flight,
One line added with care and grace,
Configuration finds its rightful place! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: adding values-prod.yaml to the icebreaker Helm configuration for Tilt.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Sheikah45-patch-1

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Tiltfile`:
- Line 412: The call to proxy_local_service_if_set has a missing comma between
the keyword arguments additional_values and config_patch, causing a Tiltfile
parse error; edit the proxy_local_service_if_set invocation (the one using
service_name="faf-icebreaker", service_chart="apps/faf-icebreaker",
service_namespace="faf-apps", service_deps=icebreaker_deps,
service_labels=icebreaker_labels,
additional_values=["apps/faf-icebreaker/values-prod.yaml"]
config_patch=icebreaker_patch) and insert a comma after the
additional_values=[...] argument so it becomes additional_values=[...] ,
config_patch=icebreaker_patch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 647541d5-8cb5-40b6-8337-146a8df04d78

📥 Commits

Reviewing files that changed from the base of the PR and between a39fb0f and db23443.

📒 Files selected for processing (1)
  • Tiltfile

Comment thread Tiltfile Outdated
@Sheikah45 Sheikah45 changed the title add values-prod.yaml to icebreaker helm for tilt add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key May 6, 2026
@Sheikah45 Sheikah45 merged commit 29d897f into develop May 6, 2026
3 checks passed
@Sheikah45 Sheikah45 deleted the Sheikah45-patch-1 branch May 6, 2026 10:10
Sheikah45 pushed a commit that referenced this pull request May 7, 2026
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key (#309)

* add values-prod.yaml to icebreaker helm for tilt

* Update Tiltfile

* Add Altcha hmac key to local secret

* Update local-secret.yaml
Sheikah45 pushed a commit that referenced this pull request May 9, 2026
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key (#309)

* add values-prod.yaml to icebreaker helm for tilt

* Update Tiltfile

* Add Altcha hmac key to local secret

* Update local-secret.yaml
Sheikah45 pushed a commit that referenced this pull request May 9, 2026
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key (#309)

* add values-prod.yaml to icebreaker helm for tilt

* Update Tiltfile

* Add Altcha hmac key to local secret

* Update local-secret.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant