add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key#309
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key#309
Conversation
📝 WalkthroughWalkthroughThe Tiltfile is updated to pass production-specific Helm values to the faf-icebreaker local service proxy by adding Changesfaf-icebreaker Helm Values Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Tiltfile`:
- Line 412: The call to proxy_local_service_if_set has a missing comma between
the keyword arguments additional_values and config_patch, causing a Tiltfile
parse error; edit the proxy_local_service_if_set invocation (the one using
service_name="faf-icebreaker", service_chart="apps/faf-icebreaker",
service_namespace="faf-apps", service_deps=icebreaker_deps,
service_labels=icebreaker_labels,
additional_values=["apps/faf-icebreaker/values-prod.yaml"]
config_patch=icebreaker_patch) and insert a comma after the
additional_values=[...] argument so it becomes additional_values=[...] ,
config_patch=icebreaker_patch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key (#309) * add values-prod.yaml to icebreaker helm for tilt * Update Tiltfile * Add Altcha hmac key to local secret * Update local-secret.yaml
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key (#309) * add values-prod.yaml to icebreaker helm for tilt * Update Tiltfile * Add Altcha hmac key to local secret * Update local-secret.yaml
add values-prod.yaml to icebreaker helm for tilt and Altcha hmac key (#309) * add values-prod.yaml to icebreaker helm for tilt * Update Tiltfile * Add Altcha hmac key to local secret * Update local-secret.yaml
Summary by CodeRabbit