upgrade to geoip2 and mmdb #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0ns
force-pushed
the
fix/#320-geoip-improve
branch
2 times, most recently
from
692877f to
308554f
Compare
faftool commit fix no localhost lookup for tests test retest retest
b0ns
force-pushed
the
fix/#320-geoip-improve
branch
from
bb3e52f to
d997396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering the issues due to misshit (frequently visible in lobbies) of ip to country translations resulting in unknown countries and filtered as "__" and considering the DEPRECATION of pygeoip the following steps have been taken:
this should enhance the geodb hit lookup rate and provide more accurate localization using also the new standard lib