Java api #370
Merged
Java api #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rackover
force-pushed
the
java_api_and_army_result_fix
branch
12 times, most recently
from
5046b5b to
15e3a16
Compare
norraxx
reviewed
Dec 2, 2018
server/api/api_accessor.py
Outdated
| async def api_patch(self, path, json_data): | ||
| headers = {'Content-type': 'application/json'} | ||
| result = self._session.request("PATCH", API_BASE_URL + path, headers=headers, json=json_data) | ||
| return result.status_code, result.text |
Collaborator
There was a problem hiding this comment.
There should be new line, event github shows it to you ;-)
Member
Author
There was a problem hiding this comment.
Yes I know \n means new line, my question is Where
| @pytest.fixture() | ||
| def service(api_accessor: ApiAccessor): | ||
| return AchievementService(api_accessor) | ||
|
|
Collaborator
There was a problem hiding this comment.
There is https://www.python.org/dev/peps/pep-0008/.
Please check it, there are some rules, how code should be formatted.
Rackover
force-pushed
the
java_api_and_army_result_fix
branch
9 times, most recently
from
68008fe to
f0d395c
Compare
norraxx
reviewed
Dec 7, 2018
server/api/api_accessor.py
Outdated
| async def api_patch(self, path, json_data): | ||
| headers = {'Content-type': 'application/json'} | ||
| result = self._session.request("PATCH", API_BASE_URL + path, headers=headers, json=json_data) | ||
| return result.status_code, result.text |
Collaborator
There was a problem hiding this comment.
There should be new line, event github shows it to you ;-)
Rackover
force-pushed
the
java_api_and_army_result_fix
branch
6 times, most recently
from
c1a480f to
a1988bc
Compare
Rackover
force-pushed
the
java_api_and_army_result_fix
branch
3 times, most recently
from
9d796bc to
8fbd41c
Compare
norraxx
suggested changes
Dec 9, 2018
server/api/api_accessor.py
Outdated
| async def api_patch(self, path, json_data): | ||
| headers = {'Content-type': 'application/json'} | ||
| result = self._session.request("PATCH", API_BASE_URL + path, headers=headers, json=json_data) | ||
| return result.status_code, result.text |
|
|
||
| def fetch_token(self, token_url, client_id, client_secret): | ||
| pass | ||
|
|
| def __init__(self): | ||
| self.status_code = 200 | ||
| self.text = "test" | ||
|
|
Rackover
force-pushed
the
java_api_and_army_result_fix
branch
from
8fbd41c to
8f1710a
Compare
Rackover
force-pushed
the
java_api_and_army_result_fix
branch
from
8f1710a to
7770163
Compare
Rackover
added a commit
to Rackover/server
that referenced
this pull request
Dec 12, 2018
Rackover
added a commit
to Rackover/server
that referenced
this pull request
Dec 12, 2018
Rackover
added a commit
that referenced
this pull request
Dec 12, 2018
Brutus5000
pushed a commit
that referenced
this pull request
Jun 24, 2019
Brutus5000
pushed a commit
that referenced
this pull request
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses java api instead of Python API
Added a config option to disable the java api since the java api is currently unable to handle achievements and events. This will allow us to update the python server early and to enable the feature later via an ENV variable.