Issue/#267 Handle client passing 'uid' as a string #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey ! |
Collaborator
Author
|
Yea I tried to request access by sending someone on the forums a message, but it was being blocked as spam. |
Member
|
I sent you a slack invite via the email included as author in your git commits. |
Geosearchef
approved these changes
Dec 29, 2018
Askaholic
added a commit
to Askaholic/server
that referenced
this pull request
Dec 30, 2018
…r#379) * Cast uid and port to int even if they are sent as strings * Added some more tests for game_join
Brutus5000
pushed a commit
that referenced
this pull request
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Adds some additional tests for
command_game_join