Integration tests update #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askaholic
force-pushed
the
integration-tests
branch
from
d6b7141 to
da64355
Compare
Member
|
Does that mean #392 is obsolete ? |
Collaborator
Author
|
Yea, this covers the game title stuff. |
Rackover
approved these changes
Mar 16, 2019
Member
|
Tested, workign, merging |
Brutus5000
pushed a commit
that referenced
this pull request
Jun 24, 2019
* Use await syntax * Move imports * Move lobby_server fixture to conftest * Added proper integration test for matchmaking search * Update test_public_host * Fix sending tutorial sections * Add local test-data.sql for server unit tests * Add test for players banned from the matchmaker * Move ladder map repetition test data into sql file * Added test for hosting a game with missing fields * Fix test merge errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the integration tests actually check something. This will be an OK way of testing things which are otherwise hard to do with unit tests because of the mocks. For example checking that a game's default title is set correctly if the host doesn't specify a title.
Added integration tests for:
I also added a test-data.sql file to this repo so that we don't need to insert data in the test themselves, and don't need to submit PR's to Faforever/db just to add some test data.