Skip to content

Conversation

@Askaholic
Copy link
Collaborator

No description provided.

Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, I would rather go for a log level that is more detailled than debug for this message.

@Askaholic
Copy link
Collaborator Author

Adding another log level doesn't solve the problem. At that point we might as well just set the log level on prod to WARN, which IMO would be OK, since as it stands the logging isn't accomplishing anything at all because no one will send me any logs :P

@Brutus5000
Copy link
Member

I cannot hand out logs due to the sheer size, and this seems the main driver behind it.

@Askaholic Askaholic changed the title Truncate lobbyconnection message logging to 100 characters Reduce server log spam May 10, 2019
@Askaholic Askaholic merged commit a50ea3a into FAForever:develop May 10, 2019
@Askaholic Askaholic deleted the reduce-logging branch May 10, 2019 19:04
Brutus5000 pushed a commit that referenced this pull request Jun 24, 2019
* Add TRACE log level, and make level configurable using environment vars

* Remove unused config variable LOBBY_IP

* Let the config be strings instead of numebrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants