Skip to content

Conversation

@Crotalus
Copy link
Member

The current problem with the lobby is that ConnectToPeer on lobby side seems to block connections completely, even the NAT processing ones.

If we instead establish connections first before we start ordering everyone to connect to eachother we will fix the problem with ppl using proxy connections when they still are able to connect.

The code in this PR isn't complete, I don't have a python work-environment so can't test the actual changes either.

Would be great if someone (@Sheeo ;)) could take a look at this, should be a quick change. What's needed is to be able to get the result from each EstablishConnection() to the later called ConnectToPeer. Either by putting that data on each peer object? Or maybe change the arguments of the function.

@Crotalus
Copy link
Member Author

Hmm, I realize await is a python 3.5 feature and server currently using 3.4? Maybe there's a similar way of doing it, I have too little experience with asyncio though

@ChrisKitching
Copy link
Contributor

server currently using 3.4

Not for long.

@Sheeo
Copy link
Member

Sheeo commented Oct 23, 2015

We're moving to python 3.5 and away from PySide. Should be done with that pretty soon.

Regarding the connectivity stuff: The current implementation you're hacking about with isn't in actual use on the server right now. It does work as well as the current one (checkout the master branch), but we're going with (co)TURN instead.

@Sheeo Sheeo closed this Oct 23, 2015
@Sheeo Sheeo removed the in progress label Oct 23, 2015
@Crotalus Crotalus deleted the refactor/establish-connections branch October 24, 2015 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants