Skip to content

Conversation

@bruvio
Copy link
Collaborator

@bruvio bruvio commented Jan 10, 2022

closes #15

added pytest markers
and moved flake8 config outside pyproject.toml as not supported by poetry.
refactored some code using sourcery

@bruvio bruvio added the enhancement New feature or request label Jan 10, 2022
@bruvio bruvio requested a review from RyanJField January 10, 2022 12:58
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #29 (0262290) into dev (5d2b6cb) will decrease coverage by 0.23%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #29      +/-   ##
==========================================
- Coverage   85.12%   84.89%   -0.24%     
==========================================
  Files           7        5       -2     
  Lines         511      503       -8     
==========================================
- Hits          435      427       -8     
  Misses         76       76              
Impacted Files Coverage Δ
fairdatapipeline/fdp_utils.py 84.53% <89.74%> (ø)
fairdatapipeline/link.py 87.17% <90.32%> (ø)
fairdatapipeline/pipeline.py 91.71% <92.53%> (ø)
fairdatapipeline/__init__.py 100.00% <100.00%> (ø)
fairdatapipeline/raise_issue.py 69.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c78c13...0262290. Read the comment docs.

@RyanJField RyanJField merged commit b052646 into dev Jan 10, 2022
@bruvio bruvio deleted the feature/pytest-markers branch January 28, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quality and covnventions

3 participants