Merged
Conversation
added 30 commits
October 24, 2024 16:39
Resolve "Create an ILIAS deployment" See merge request xe66gydo/assSQLQuestion!1
added 21 commits
March 11, 2025 08:08
…e-ilias-9' Scoring/testing examples (SQLite specific) See merge request xe66gydo/assSQLQuestion!7
…te-ilias-9' Resolve "Ensure type safety with database queries" See merge request xe66gydo/assSQLQuestion!12
…as-9' Format bigbang, PSR-12 See merge request xe66gydo/assSQLQuestion!13
Update CodeMirror to v6 See merge request xe66gydo/assSQLQuestion!14
UI text improvements See merge request xe66gydo/assSQLQuestion!15
Do the switch to support mainly ILIAS 9 Closes #25, #26, #12, #20, #21, #22, #18, and #15 See merge request xe66gydo/assSQLQuestion!16
Transfer CodeMirror content on execution Closes #38 See merge request xe66gydo/assSQLQuestion!17
Collaborator
Author
|
LGTM |
…access (#3) * README: Switch to permalink * Code Style Fixes * Fix calculateReachedPoints * Fix for unanswered questions * Allow partial points by using floats instead of ints * Add a test suite * Fix FunctionalDependencies Amount Bug * FunctionalDependencies: Simplify Early Return * Add Test for Commutativity - FunctionalDependencies --------- Co-authored-by: Marco Angerer <marco.angerer@fau.de>
dominik-probst
approved these changes
Jun 5, 2025
Member
dominik-probst
left a comment
dominik-probst
left a comment
There was a problem hiding this comment.
A superficial code review did not reveal any major issues: it's definitely sufficient for the main branch, making it easier to report the new version to the ILI.
If anything comes up during the more detailed code review as part of the project evaluation, I will of course reach out :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.