fix: reset uv.lock before the base benchmark run#111
Conversation
The head run leaves an untracked uv.lock behind, and uv keeps a satisfying lockfile as-is — so a head that changes dependencies leaked its resolution into the base run (both sides benchmarked the head's deps). Remove it before the base run and log each side's resolved tsam version for transparency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe benchmark workflow now prints the ChangesBenchmark workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
BenchmarksΔ% vs base, one table sorted by biggest change first Full tablebenchmarks/test_bench_aggregate.py
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/benchmarks.yaml:
- Line 61: Update the base benchmark’s uv invocation before the benchmarks
pytest command to perform an exact environment sync by adding the supported
exact-sync option to uv run. Keep the existing BENCHMEM, benchmark path, and
BENCH_ARGS behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1794ea81-3a7c-478e-8a31-aa0b34ebd072
📒 Files selected for processing (1)
.github/workflows/benchmarks.yaml
uv run syncs inexactly by default and leaves extraneous packages from the head resolution installed; --exact removes them so the base runs on exactly its own dependency set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The head benchmark run leaves an untracked
uv.lockbehind, and uv keeps a satisfying lockfile as-is — so a head that changes dependencies leaked its resolution into the base run and both sides benchmarked the head's dependencies (discovered on #110, where the v4-vs-v3 comparison silently became v4-vs-v4). Remove the lock before the base run so base re-resolves from its ownpyproject.toml, and log each side's resolved tsam version so this is visible in the job log.🤖 Generated with Claude Code
Summary by CodeRabbit