[Feat] number type 문자로 포맷 #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssumanlife
requested review from
a user,
devdeun,
kimpra2989 and
nanafromjeju
devdeun
reviewed
Dec 2, 2024
shared/utils/format.ts
Outdated
|
|
||
| export const formatNumber = (data: number): string | number => { | ||
| if (data.toFixed(0).toString().length > 3) { | ||
| return data.toFixed(0).replace(/\B(?=(\d{3})+(?!\d))/g, ',') |
Contributor
There was a problem hiding this comment.
toLocaleString 이라는 메소드가 있긴한데..!
kimpra2989
temporarily deployed
to
feat/format-number-188 - FinalProject_team3_FE PR #194
Render
Destroyed
ghost
approved these changes
Dec 3, 2024
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
🔍 작업 내용
number type 문자로 포맷
🔧 변경 사항
📸 스크린샷 (권장)
🙏 리뷰 참고 (선택 사항)
정수 4자리수 이상의 숫자만 포맷하도록 하고 아닌 것은 원래 데이터 return 하도록 적용
📄 기타 (선택 사항)