Skip to content

Conversation

@kimpra2989
Copy link
Contributor

🚀 풀 리퀘스트 제안

🔍 작업 내용

admin category에서

  1. Suspense가 적용되지 않던 부분에 대해 useSuspenseQuery와 withSuspense로 스켈레톤이 정상적으로 작동하도록 수정했습니다.
  2. 초반에 axiosInstance를 사용하지 않고 axios로 요청을 보내서 배포된 페이지에서 403 권한 오류가 나던 곳들을 수정했습니다.

@kimpra2989 kimpra2989 added the 🐛 Bug 버그 label Dec 6, 2024
@kimpra2989 kimpra2989 self-assigned this Dec 6, 2024
@kimpra2989 kimpra2989 temporarily deployed to fix/admin-category-page-162 - FinalProject_team3_FE PR #307 December 6, 2024 04:19 — with Render Destroyed
{tableHead?.map((head) => <td key={head}>{head}</td>)}
{isEditable && <td></td>}
</tr>
<tr>{tableHead?.map((head) => <td key={head}>{head}</td>)}</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isEditable 지우면 안될거같아요!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 스켈레톤이라 지우신것같은데 isEditable 스켈레톤에서도 쓰이나요??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 스켈레톤이구나 잘못봤어여

Copy link
Contributor

@devdeun devdeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@ssumanlife ssumanlife merged commit e624c01 into develop Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 Bug 버그

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants