Conversation
First of all, don't use positional parameter of role's signature where it is used at compile-time. In particular, `is default` would then unconditionally be set to `Mu` because this is what is the positional's value when role body is compiled. Second, override `of` method because the default one relies on hash own container descriptor and knows nothing about role's value type.
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, don't use positional parameter of role's signature where it is used at compile-time. In particular,
is defaultwould then unconditionally be set toMubecause this is what is the positional's value when role body is compiled.Second, override
ofmethod because the default one relies on hash own container descriptor and knows nothing about role's value type.