Make operator candidates for Enumeration RHS#496
Merged
FCO merged 1 commit intoFCO:masterfrom Jun 10, 2022
Merged
Conversation
It would seem that there are more specific core operator candidates for '==' and 'eq' with an Enumeration RHS so these won't be handled by Red leading to suprising results. Only implemented for equality operators (and IN,) as I'm not sure whether any other operators make sense. Fixes the FCO#495
Owner
|
I was trying to make new operators alternatives for |
Owner
|
I am thinking about something like this, what do you think? (that's not working yet) |
Contributor
Author
|
If it can be made to work like that, then all good. It's better to have it in the core of the value handling than adding new operators all the time. |
Owner
|
Would you like to help with that? It's being difficult to find time to that currently (I'll probably only have time for that on the weekend) |
Contributor
Author
|
I'll take a look, but I'm trying to have a slack week :-D |
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would seem that there are more specific core operator candidates
for '==' and 'eq' with an Enumeration RHS so these won't be handled by
Red leading to suprising results.
Only implemented for equality operators (and IN,) as I'm not sure
whether any other operators make sense.
Fixes the #495