Skip to content

CI: Add validation#13

Merged
PerditionC merged 7 commits intoFDOS:masterfrom
andrewbird:ci-02
Feb 1, 2026
Merged

CI: Add validation#13
PerditionC merged 7 commits intoFDOS:masterfrom
andrewbird:ci-02

Conversation

@andrewbird
Copy link
Contributor

No description provided.

@andrewbird
Copy link
Contributor Author

@fritzmueller @PerditionC I fixed up the current tables to pass validation. I'd appreciate it if you could review the Country changes especially the last, Montenegro, as I had to make most of that up. Ooh, they're using the Euro without permission - nice!

@PerditionC
Copy link
Contributor

I will try looking later this evening, if not it won't be until Friday that I have a chance again. I have some improvements to the source to minimize mistakes (850 vs 858 type) and improve readability via some additional macros.

@fritzmueller
Copy link

fritzmueller commented Jan 28, 2026 via email

@fritzmueller
Copy link

fritzmueller commented Jan 28, 2026 via email

@andrewbird
Copy link
Contributor Author

Thanks for the info, you obviously know this stuff well. I've updated the currency values in line with what Wikipedia says is the currency in use. Only Serbia differed from your AI list above, says they are still using Serbian Dinar. That's probably as much as I want to do on this at the moment.

@andrewbird andrewbird marked this pull request as ready for review January 28, 2026 14:00
@fritzmueller
Copy link

fritzmueller commented Jan 28, 2026 via email

@andrewbird
Copy link
Contributor Author

Yes I briefly had a conversation with Jerome where he explained the Human / AI split, mainly because I expressed surprise that some AI translations were replacing existing human ones (that were presumably produced by a native speaker). I'm glad they have a plan in place to manage this and as you say it's quite an undertaking.

@andrewbird
Copy link
Contributor Author

@PerditionC don't worry about breaking / fixing the validation with your refactoring with macros clean up. I'll fix it up afterwards to work with your new scheme.

@fritzmueller
Copy link

fritzmueller commented Jan 28, 2026 via email

@andrewbird
Copy link
Contributor Author

I am not sure if you know that "EU is not Europe".

Yes I'm in UK, no longer EU, but still Europe. 😄

@andrewbird andrewbird marked this pull request as draft January 28, 2026 21:07
@andrewbird
Copy link
Contributor Author

Will have to review whether the 785 Arabic should be retained, so don't merge yet.

@andrewbird andrewbird marked this pull request as ready for review January 29, 2026 01:54
@andrewbird
Copy link
Contributor Author

Renamed the me to xx to retain Middle East and added new entries for Montenegro.

1/ Now two separate countries
	CZ : 420
	SK : 421

2/ Slovakia now uses Euro
ISO3166-1-Alpha2 code is RS not SR
1/ International Phone Prefix is 385 not 384

2/ Currency is EURO
Note: the other devolved countries already have entries, but
    Kosovo was missing. Perhaps because only a temporary code (xk)
    has been issued for ISO3166-1-Alpha2.

    Kosovo now uses the EURO
Previously there was a seemingly invented code 'me' for Middle East,
with a International Phone Prefix 785 that apparently belonged to
the former Soviet Union. Now Montenegro has been allocated the 'me'
code rename to 'xx'. ISO 3166-1-Alpha2 has that defined as 'The code
XX is used by WIPO as an indicator for unknown states, other entities
or organizations'.
@PerditionC PerditionC merged commit 30c70ed into FDOS:master Feb 1, 2026
1 check passed
@andrewbird andrewbird deleted the ci-02 branch February 1, 2026 10:17
@fritzmueller
Copy link

fritzmueller commented Feb 1, 2026 via email

@andrewbird
Copy link
Contributor Author

Hi Fritz,
we split the task. @PerditionC has a different PR #10 that deals with some of those. At the moment it has conflicts as my Czechoslovakia / Yugoslavia changes got merged first, so I did a rebase and deconflict of it as a test PR #14.

@PerditionC
Copy link
Contributor

updated Ukraine with additional codepages, but 855/848 and similarly 866/1125 should be largely compatible.

I believe the Iceland, ... Sweden ... stuff is supported already.

Please see #15 for latest updates. I will try and post a build of country.sys for testing soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants