Skip to content

Ensure scheduled post-meeting-notes runs execute with dry-run disabled#351

Merged
ondrej-fabry merged 2 commits intomasterfrom
copilot/fix-post-meeting-notes-dry-run
Mar 19, 2026
Merged

Ensure scheduled post-meeting-notes runs execute with dry-run disabled#351
ondrej-fabry merged 2 commits intomasterfrom
copilot/fix-post-meeting-notes-dry-run

Conversation

Copy link
Contributor

Copilot AI commented Mar 19, 2026

Scheduled executions of post-meeting-notes.yaml were unintentionally treated as dry-runs because workflow_dispatch inputs are absent on cron triggers, causing the script fallback ("true") to take effect. This change makes scheduled runs post comments normally while preserving manual dry-run control.

  • Workflow behavior fix

    • Updated DRY_RUN env assignment to branch on trigger type:
      • schedule → force "false"
      • workflow_dispatch → keep inputs.dry_run
  • Scope

    • Single-line change in .github/workflows/post-meeting-notes.yaml
    • No changes to note discovery, filtering, or posting logic in the embedded Python script
DRY_RUN: ${{ github.event_name == 'schedule' && 'false' || github.event.inputs.dry_run }}

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

Co-authored-by: ondrej-fabry <32484950+ondrej-fabry@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix post-meeting notes generation for scheduled runs Ensure scheduled post-meeting-notes runs execute with dry-run disabled Mar 19, 2026
Copilot AI requested a review from ondrej-fabry March 19, 2026 11:56
@ondrej-fabry ondrej-fabry marked this pull request as ready for review March 19, 2026 11:58
@ondrej-fabry ondrej-fabry merged commit 3c2dd38 into master Mar 19, 2026
11 checks passed
@ondrej-fabry ondrej-fabry deleted the copilot/fix-post-meeting-notes-dry-run branch March 19, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants