fix: 兼容 publicPath 为绝对路径的 url 的情况#27
Merged
levy9527 merged 2 commits intoFEMessage:devfrom Oct 20, 2020
Merged
Conversation
snowlocked
approved these changes
Oct 19, 2020
colmugx
approved these changes
Oct 19, 2020
Contributor
|
@all-contributors add @gd4Ark code and bug |
Contributor
|
I've put up a pull request to add @gd4Ark! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
以前的写法只支持传入相对路径的 publicPath，因为是使用
path.join()进行拼接，所以传入带协议的 url，就会被转换为路径How
在原有的基础上，判断 publicPath 是否一个 绝对路径的 url（http 或者 // 开头
如果是，则使用
url.resolve()拼接 urlTest