Add more PETSc destruction notes to assembly functionality that creates PETSc.Mat/Vec objects #3524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es petsc vec/mat objects. Uncovered in: #3522 (comment)
Member
|
I think we should have the 'note' text appear in one place in the docs and refer (link) to it where appropriated. We have duplicated the text in a lot of places. |
Member
Author
I guess the most natural place is to have one under create_matrix and another under create_vector, and the have references everywhere else. |
schnellerhase
pushed a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
…es PETSc.Mat/Vec objects (FEniCS#3524) * Add more PETSc destruction notes to assembly functionality that creates petsc vec/mat objects. Uncovered in: FEniCS#3522 (comment) * Ruff formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of: #3329
Uncovered in: #3522 (comment)