Skip to content

Conversation

@michalhabera
Copy link
Contributor

Fixes #3850

@schnellerhase
Copy link
Contributor

schnellerhase commented Aug 13, 2025

Thanks, should we add a test case for this? There seems to be no test case checking or using the returned DOF-map.

Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
@michalhabera
Copy link
Contributor Author

I was also thinking about making std::vector<int32_t>, std::vector<int64_t>, std::vector<double> opaque in nanobind, so we avoid any of these performance issues in future.

@garth-wells garth-wells added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit e5ee6ae Aug 18, 2025
30 checks passed
@garth-wells garth-wells deleted the michal/wrap-collapsed-dofmap branch August 18, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FunctionSpace.collapse returns list, not ndarray

4 participants