Strip whitespace from $arch and use cl.exe instead of "cl".#1
Merged
mstorsjo merged 1 commit intoFFmpeg:masterfrom Apr 24, 2024
Merged
Strip whitespace from $arch and use cl.exe instead of "cl".#1mstorsjo merged 1 commit intoFFmpeg:masterfrom
mstorsjo merged 1 commit intoFFmpeg:masterfrom
Conversation
Member
|
Hi! I didn't see this PR before, as we don't usually use PRs for contributions here (we normally just send patches for review at ffmpeg-devel, even if this is a separate repo). I just merged a similar change from #1, but the other change, about stripping whitespace from I can merge this, updating the commit message to reflect that the cl.exe change no longer ended up contained in this commit. |
The output of the "arch" command ends with a newline, thus not matching any of the architectures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of the "arch" command ends with a newline, thus not
matching any of the architectures.
When running under wsl it is necessary to specify the extension,
so prefer the full cl.exe name instead of just "cl".