Fix types root in package.json #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types root incorrrectly pointed to the app types instead of the index types. This prevented GoFSH from being imported property in other applications.
mint-thompson
approved these changes
Oct 31, 2024
Collaborator
mint-thompson
left a comment
mint-thompson
left a comment
There was a problem hiding this comment.
Worked perfectly for me: compile errors without the change, no compile errors with the change. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This sets the types root to
dist/index.d.ts. Previously, the types root pointed todist/app.d.ts, which prevented GoFSH from being imported property in other applications.Testing Instructions:
Repro the problem:
npm installnpm run buildand observe compile errorsTest the solution:
npm packto create the module filegofsh-2.3.1.tgzgofsh-2.3.1.tgzto the simple TS project you downloadednpm install --save file:gofsh-2.3.1.tgznpm run buildand observe that it builds cleanlyRelated Issue: Discovered and discussed in FSH VS Code PR #97